[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

[Tom Honermann via Phabricator via cfe-commits]

tahonermann added inline comments.


================
Comment at: clang/docs/ClangCommandLineReference.rst:1183-1185
+.. option:: -fmodule-header=\[user,system\]
+
+Build a C++20 header unit, but search for the header in the user or system header search paths respectively.
----------------
Are "user" and "system" the right terms to use here? Existing options aren't all that consistent. Some examples from `Options.td`:
  def MD : Flag<["-"], "MD">, Group<M_Group>,
      HelpText<"Write a depfile containing user and system headers">;
  def MMD : Flag<["-"], "MMD">, Group<M_Group>,
      HelpText<"Write a depfile containing user headers">;
  ...
  def iquote : JoinedOrSeparate<["-"], "iquote">, Group<clang_i_Group>, Flags<[CC1Option]>,
    HelpText<"Add directory to QUOTE include search path">, MetaVarName<"<directory>">;
  def isystem : JoinedOrSeparate<["-"], "isystem">, Group<clang_i_Group>,
    Flags<[CC1Option]>,
    HelpText<"Add directory to SYSTEM include search path">, MetaVarName<"<directory>">;

For comparison, the related MSVC options (also present in `Options.td`) are:
  def _SLASH_headerUnitAngle : CLJoinedOrSeparate<"headerUnit:angle">;
  def _SLASH_headerUnitQuote : CLJoinedOrSeparate<"headerUnit:quote">;

Should there be a "both" or "any" option so that the search considers all include paths as opposed to just user OR system?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121589/new/

https://reviews.llvm.org/D121589