[PATCH] D124396: [HIP] Fix diag msg about sanitizer

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 25 11:19:15 PDT 2022


yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:113-114
 def warn_drv_unsupported_option_for_offload_arch_req_feature : Warning<
-  "ignoring '%0' option as it is not currently supported for "
-  "offload arch '%1'. Use it with an offload arch containing '%2' instead">,
+  "ignoring '%0' option for offload arch '%1' as it is not currently supported for "
+  "that offload arch. Use it with an offload arch containing '%2' instead">,
   InGroup<OptionIgnored>;
----------------
tra wrote:
> 'there' would be more concise and less repetitive.
will do when committing


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124396/new/

https://reviews.llvm.org/D124396



More information about the cfe-commits mailing list