[PATCH] D124250: [Serialization] write expr dependence bits as a single integer

Sam McCall via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 25 08:24:32 PDT 2022


Hi Jake,

I suspect something about the test/runner is nonhermetic, I'm going to try
to fix it in the test.

This commit changes the serialized PCH format.
It looks like this test is not properly hermetic, and is trying to load the
PCH from a previous run of the test. It clears the module dir, but not the
PCH itself.
This would normally trigger a version mismatch error, but the test disables
it with -fdisable-module-hash for some reason.

Only mystery is why the c-index-test line doesn't fail if it doesn't manage
to overwrite the PCH file.

On Mon, Apr 25, 2022 at 4:59 PM Jake Egan via Phabricator <
reviews at reviews.llvm.org> wrote:

> Jake-Egan added a comment.
>
> Hi, this broke a test on AIX
> https://lab.llvm.org/buildbot/#/builders/214/builds/903/steps/6/logs/FAIL__Clang__pch-with-module_m
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D124250/new/
>
> https://reviews.llvm.org/D124250
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220425/17c97658/attachment.html>


More information about the cfe-commits mailing list