[PATCH] D124104: [clang][dataflow] Fix `Environment::join`'s handling of flow condition merging

Mon Apr 25 08:03:33 PDT 2022

sgatev accepted this revision.
sgatev added inline comments.

================
Comment at: clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:356
+
+    return V1 == V2 ||
+           Env1.flowConditionImplies(*V1) == Env2.flowConditionImplies(*V2);
----------------
ymandel wrote:
> sgatev wrote:
> > That's guaranteed to be false in `compareEquivalent`.
> I thought just `Val1 == Val2` was guaranteed false? Also, I see that the variable naming could be confusing, so I've renamed.
Right. I think I misread it. Having `IsSet1 == IsSet2` here makes sense to me. Though, if the test only needs the second part, I suggest removing this to simplify the setup.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124104/new/

https://reviews.llvm.org/D124104