[PATCH] D122663: Mark identifier prefixes as substitutable

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 25 06:57:27 PDT 2022

erichkeane added a comment.

In D122663#3470687 <https://reviews.llvm.org/D122663#3470687>, @hvdijk wrote:

> In D122663#3457330 <https://reviews.llvm.org/D122663#3457330>, @erichkeane wrote:
>> LGTM!  I would like @rjmccall to take a pass if he ends up having time in the next day or two (perhaps tack on an extra day or two because of Easter), else I'll be willing to approve later in the week.
> ping, I did get feedback from @rsmith (much appreciated) and applied his suggestions, but not from @rjmccall, would you be okay to approve it then?

Ping me EOW if @rsmith doesn't respond in the meantime.  It is also not clear to me whether you were able to capture/fix the issue he had with the clang-abi-compat.cpp test.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list