[PATCH] D124344: [clangd] Output inlay hints with `clangd --check`

[Nathan Ridge via Phabricator via cfe-commits]

nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.

Thanks, this seems useful.



================
Comment at: clang-tools-extra/clangd/tool/Check.cpp:195
 
+  // Build Inlay Hints for the entire AST
+  bool buildInlayHints(llvm::Optional<Range> LineRange) {
----------------
The comment should probably say "... for the entire AST or the specified range"


================
Comment at: clang-tools-extra/clangd/tool/Check.cpp:201
+    for (const auto &Hint : Hints) {
+      vlog("  {0} {1}", Hint.position, Hint.label);
+    }
----------------
Might be useful for print the hint kind as well?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124344/new/

https://reviews.llvm.org/D124344