[PATCH] D124287: [modules][ODRHash] Compare ODR hashes to detect mismatches in duplicate ObjCInterfaceDecl.
Volodymyr Sapsai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 22 11:39:42 PDT 2022
vsapsai created this revision.
vsapsai added reviewers: jansvoboda11, rsmith, bruno.
Herald added a subscriber: ributzka.
Herald added a project: All.
vsapsai requested review of this revision.
Herald added a project: clang.
The purpose of the change is to start using ODR hash for comparison
instead of ASTStructuralEquivalence and ODR hash calculation is,
unfortunately, incomplete. The decision to use ODR hash is made because
we can use the same mechanism while checking duplicates encountered
during deserialization. For that case ASTStructuralEquivalence is not a
good fit because it can lead to excessive deserialization and
deserialized decls would be used only for ASTStructuralEquivalence.
rdar://82908223
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D124287
Files:
clang/include/clang/AST/DeclObjC.h
clang/include/clang/AST/ODRHash.h
clang/include/clang/Sema/Sema.h
clang/lib/AST/DeclObjC.cpp
clang/lib/AST/ODRHash.cpp
clang/lib/Parse/ParseObjc.cpp
clang/test/Modules/compare-objc-interface.m
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D124287.424552.patch
Type: text/x-patch
Size: 9435 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220422/6db3a67f/attachment.bin>
More information about the cfe-commits
mailing list