[PATCH] D124238: [AST] QualifiedTemplateName::getTemplateDecl cleanup.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 22 03:10:39 PDT 2022


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/AST/ItaniumMangle.cpp:2206
   switch (TN.getKind()) {
   case TemplateName::QualifiedTemplate:
+    TD = TN.getAsQualifiedTemplateName()
----------------
can't this just be TN.getAsTemplateDecl() and tacked onto the next case?


================
Comment at: clang/tools/libclang/CIndex.cpp:1465
     // FIXME: Visit nested-name-specifier.
-    return Visit(MakeCursorTemplateRef(
-        Name.getAsQualifiedTemplateName()->getTemplateDecl(), Loc, TU));
+    return Visit(MakeCursorTemplateRef(Name.getAsQualifiedTemplateName()
+                                           ->getUnderlyingTemplate()
----------------
this can be handled along with the Template/UsingTemplate cases (apart from the fixme)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124238/new/

https://reviews.llvm.org/D124238



More information about the cfe-commits mailing list