[PATCH] D124186: [RISCV] Fix incorrect policy implement for unmasked vslidedown and vslideup.

Thu Apr 21 22:02:51 PDT 2022

khchen added a comment.

In D124186#3465136 <https://reviews.llvm.org/D124186#3465136>, @craig.topper wrote:

> The intrinsic interface doesn't care about 0<i<vstart for slidedown. We don't give user control of vstart. Nearly every instruction is undisturbed for 0<i<vstart.
>
> But having said that it probably makes sense to keep the vslideup/down interface the same.

In D124186#3465136 <https://reviews.llvm.org/D124186#3465136>, @craig.topper wrote:

> The intrinsic interface doesn't care about 0<i<vstart for slidedown. We don't give user control of vstart. Nearly every instruction is undisturbed for 0<i<vstart.
>
> But having said that it probably makes sense to keep the vslideup/down interface the same.

Yes I know, but I didn't clarify that in comment, thanks for your advice.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124186/new/

https://reviews.llvm.org/D124186