[PATCH] D119996: [safestack] Support safestack in stack size diagnostics

Thu Apr 21 14:35:26 PDT 2022

paulkirth added a comment.

In D119996#3465735 <https://reviews.llvm.org/D119996#3465735>, @vvereschaka wrote:

> Hi @paulkirth,
>
> using of specific triple within `stack-usage-safestack.c` test causes a failure for the compilers, which don't support these triples (arm/aarch64 in my case).
> Such as:
>
>   error: unable to create target: 'No available targets are compatible with triple "i386-apple-darwin"'
>
> see more details in https://lab.llvm.org/buildbot/#/builders/119/builds/8169/steps/9/logs/FAIL__Clang__stack-usage-safestack_c result for the failed build.
>
> would you fix the test by removing these triples from the command line or by isolating this test for specific target with `// REQUIRES:` directive?

Oh, that's surprising. I followed the procedure from another test, so I'm surprised that this is failing when that one is not, but maybe I missed the `REQUIRES` directive.  I can probably get a change out fairly quickly, but if its blocking you, feel free to revert this and we can re-land later.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119996/new/

https://reviews.llvm.org/D119996