[PATCH] D124180: [Frontend] avoid copy of PCH data when PrecompiledPreamble stores it in memory

Thu Apr 21 11:53:16 PDT 2022

sammccall added a comment.

In D124180#3465304 <https://reviews.llvm.org/D124180#3465304>, @thakis wrote:

> I think this might've broken check-clangd: http://45.33.8.238/linux/74320/step_9.txt
>
> The output isn't very useful though, I'm guessing @yln's recent gtest runner change it's not getting printed.

Thanks, I've reverted this change and fortunately it reproduces locally (I had only run the clang tests, oops).

I'm really concerned about the test runner change though: it means bots yield essentially no information from crashes (no test name, no stack trace).
So if a crash occurs in a bot config but not locally, there's no clear way to debug it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124180/new/

https://reviews.llvm.org/D124180