[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 21 05:46:11 PDT 2022
sammccall created this revision.
sammccall added reviewers: kbobyrev, CJ-Johnson.
Herald added subscribers: usaxena95, kadircet, mgrang, mgorny.
Herald added a project: All.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added projects: clang, clang-tools-extra.
Include-cleaner is a library that uses the clang AST and preprocessor to
determine which headers are used. It will be used in clang-tidy, in
clangd, in a standalone tool at least for testing, and in out-of-tree tools.
Roughly, it walks the AST, finds referenced decls, maps these to
used sourcelocations, then to FileEntrys, then matching these against #includes.
However there are many wrinkles: dealing with macros, standard library
symbols, umbrella headers, IWYU directives etc.
It is not built on the C++20 modules concept of usage, to allow:
- use with existing non-modules codebases
- a flexible API embeddable in clang-tidy, clangd, and other tools
- avoiding a chicken-and-egg problem where include cleanups are needed before modules can be adopted
This library is based on existing functionality in clangd that provides
an unused-include warning. However it has design changes:
- it accommodates diagnosing missing includes too (this means tracking where references come from, not just the set of targets)
- it more clearly separates the different mappings (symbol => location => header => include) for better testing
- it handles special cases like standard library symbols and IWYU directives more elegantly by adding unified Location and Header types instead of side-tables
- it will support some customization of policy where necessary (e.g. for style questions of what constitutes a use, or to allow both missing-include and unused-include modes to be conservative)
This patch adds the basic directory structure under clang-tools-extra
and a skeleton version of the AST traversal, which will be the central
A more end-to-end prototype is in https://reviews.llvm.org/D122677
rG LLVM Github Monorepo
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 15291 bytes
Desc: not available
More information about the cfe-commits