[PATCH] D124154: [clangd] Fix a declare-constructor tweak crash on incomplete fields.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 21 04:02:40 PDT 2022
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/refactor/tweaks/MemberwiseConstructor.cpp:182
+ if (!C.hasDefinition())
+ return Skip;
// We can't always tell if C is copyable/movable without doing Sema work.
----------------
Fail instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124154/new/
https://reviews.llvm.org/D124154
More information about the cfe-commits
mailing list