[PATCH] D122983: [C11/C2x] Change the behavior of the implicit function declaration warning

Nemanja Ivanovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 20 17:45:52 PDT 2022


nemanjai added a comment.

This is still causing failures when building `test-suite`:
https://lab.llvm.org/buildbot/#/builders/105/builds/24292

Why don't we just turn off this warning for the entire `test-suite` since I don't expect we want to modify the tests (as some of them have licenses that probably don't allow us to modify them)?
We could do something like this:

  diff --git a/CMakeLists.txt b/CMakeLists.txt
  index 8d76a45c7..032281ecf 100644
  --- a/CMakeLists.txt
  +++ b/CMakeLists.txt
  @@ -47,6 +47,7 @@ set(LLVM_CODESIGNING_IDENTITY "" CACHE STRING
     "Sign executables and dylibs with the given identity or skip if empty (Darwin Only)")
   
   add_definitions(-DNDEBUG)
  +add_definitions(-Wno-implicit-function-declaration)
   option(TEST_SUITE_SUPPRESS_WARNINGS "Suppress all warnings" ON)
   if(${TEST_SUITE_SUPPRESS_WARNINGS})
     add_definitions(-w)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122983/new/

https://reviews.llvm.org/D122983



More information about the cfe-commits mailing list