[PATCH] D124104: [clang][dataflow] Fix `Environment::join`'s handling of flow condition merging

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun accepted this revision.
xazax.hun added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:69
 
 /// Attempts to merge distinct values `Val1` and `Val1` in `Env1` and `Env2`,
 /// respectively, of the same type `Type`. Merging generally produces a single
----------------
Typo: `Val2`.


================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:73
 /// meaning depends on `Model`.
 static Value *mergeDistinctValues(QualType Type, Value *Val1, Environment &Env1,
                                   Value *Val2, const Environment &Env2,
----------------
Would it make sense to make `Env1` const?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124104/new/

https://reviews.llvm.org/D124104