[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 20 11:51:56 PDT 2022


erichkeane added inline comments.


================
Comment at: clang/lib/Sema/TreeTransform.h:13165
+    //                  when checking satisfaction.
+    NewTrailingRequiresClause = getDerived().TransformExpr(TRC);
+
----------------
So I just noticed this: What happens when NewTrailingRequiresClause is invalid here? I think the call to 'get' below on this would assert, right?  This perhaps needs to return ExprError in that case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124012/new/

https://reviews.llvm.org/D124012



More information about the cfe-commits mailing list