[PATCH] D123854: [clang][lex] NFCI: Use DirectoryEntryRef in FrameworkCacheEntry

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 marked 3 inline comments as done.
jansvoboda11 added inline comments.


================
Comment at: clang/lib/Lex/HeaderSearch.cpp:607
     // If the framework dir doesn't exist, we fail.
     auto Dir = FileMgr.getDirectory(FrameworkName);
     if (!Dir)
----------------
bnbarham wrote:
> Is the plan to do these ones in later commits? Ie. this just does what's needed for `FrameworkCacheEntry`?
I don't see a `Dir->getName()` call in this function, so I think we're fine just leaving this as `const DirectoryEntry *`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123854/new/

https://reviews.llvm.org/D123854