[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

Wed Apr 20 08:20:30 PDT 2022

paulkirth added a comment.

Hi I think this patch is the root cause of https://github.com/llvm/llvm-project/issues/54968

The issue first appears in our builders here:
https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-release/b8816803488685972465/overview

based on the blamelist (https://luci-milo.appspot.com/ui/p/fuchsia/builders/ci/clang_toolchain.ci.core.x64-release/b8816803488685972465/blamelist) I'm fairly certain that this change is responsible.

I'm guessing that there is some additional case the new branch condition is missing that causes the assertion failure to manifest.

If this will be hard to fix, can you revert this patch until one is ready?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123840/new/

https://reviews.llvm.org/D123840