[PATCH] D123212: [clangd] Handle the new UsingTemplateName.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 20 06:42:30 PDT 2022


sammccall accepted this revision.
sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:82
   bool VisitTemplateSpecializationType(TemplateSpecializationType *TST) {
-    add(TST->getTemplateName().getAsTemplateDecl()); // Primary template.
+    // Using templateName case is handled by the override TraverseTemplateName.
+    if (TST->getTemplateName().getKind() == TemplateName::UsingTemplate)
----------------
maybe instead:
"Use of a template through an alias only uses the alias (see VisitTemplateName), not the underlying template"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123212/new/

https://reviews.llvm.org/D123212



More information about the cfe-commits mailing list