[PATCH] D124081: [clang] [WIP] Reject non-declaration C++11 attributes on declarations.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 20 06:11:56 PDT 2022

aaron.ballman added a comment.

In D124081#3461742 <https://reviews.llvm.org/D124081#3461742>, @mboehme wrote:

> In D124081#3461731 <https://reviews.llvm.org/D124081#3461731>, @aaron.ballman wrote:
>> In D124081#3461556 <https://reviews.llvm.org/D124081#3461556>, @mboehme wrote:
>>> I'd like to mark this patch as a draft so that Herald doesn't keep adding reviewers -- but I'm not sure how?
>> In that case, I usually set the permissions on the review explicitly so that I'm the only one who can view the draft (but this means precommit CI won't run on it).
> In this case, though, I want to be able to show the draft to others and discuss it with them. I guess this technique doesn't work for that?

FWIW, you can pick the specific list of folks you want to give permissions to if you know it's a limited group. (I've done this with Erich from time to time when I want a second set of eyes on an NFC change but don't want to bother the mailing lists with it.) However, it sounds to me like you want anyone to be able to come by and comment if they'd like while you're prepping the patch, so I'd stick with the [WIP] in the title like you've got.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list