[PATCH] D124081: [clang] [draft] Reject non-declaration C++11 attributes on declarations.

Martin Böhme via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 20 06:08:26 PDT 2022

mboehme added a comment.

In D124081#3461731 <https://reviews.llvm.org/D124081#3461731>, @aaron.ballman wrote:

> In D124081#3461556 <https://reviews.llvm.org/D124081#3461556>, @mboehme wrote:
>> I'd like to mark this patch as a draft so that Herald doesn't keep adding reviewers -- but I'm not sure how?
> In that case, I usually set the permissions on the review explicitly so that I'm the only one who can view the draft (but this means precommit CI won't run on it).

In this case, though, I want to be able to show the draft to others and discuss it with them. I guess this technique doesn't work for that?

> Most often folks just add [WIP] to the title and reviewers know to ignore the review until the [WIP] is removed.

Ah -- thanks. I'll add [WIP[ then.

  rG LLVM Github Monorepo



More information about the cfe-commits mailing list