[PATCH] D123668: [Testing] TestAST, a helper for writing straight-line AST tests

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.

Thanks, this looks good; just few nits regarding the comments.



================
Comment at: clang/include/clang/Testing/TestAST.h:9
+//
+// In normal operation of clang, the FrontendAction's lifecycle both creates
+// and destroys the AST, and code should operate on it during callbacks in
----------------
nit: capitalization


================
Comment at: clang/include/clang/Testing/TestAST.h:33
+
+/// TestInputs specifies a virtual source file to be parsed as part of a test.
+struct TestInputs {
----------------
nit: omit `TestInputs` since it's the document for that.


================
Comment at: clang/include/clang/Testing/TestAST.h:54
+
+/// TestAST is the result of parsing a file, as specified by TestInputs.
+///
----------------



================
Comment at: clang/include/clang/Testing/TestAST.h:70
+
+  /// Provides access to the AST context and other parts of clang.
+
----------------



================
Comment at: clang/lib/Testing/TestAST.cpp:1
+//===--- TestAST.cpp
+//--------------------------------------------------------===//
----------------
nit: comment seems broken


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123668/new/

https://reviews.llvm.org/D123668