[PATCH] D123610: [Testing] Drop clangTesting from clang's public library interface

[Sam McCall via Phabricator via cfe-commits]

sammccall added inline comments.


================
Comment at: clang/lib/Testing/CMakeLists.txt:6
+# Not add_clang_library: this is not part of clang's public library interface.
+# Unit tests should depend on this with target_link_libraries, not clang_TLL.
+add_llvm_library(clangTesting
----------------
hokein wrote:
> OOO, what is `clang_TLL`?
clang_target_link_libraries, spelled it out


================
Comment at: clang/lib/Testing/CMakeLists.txt:7
+# Unit tests should depend on this with target_link_libraries, not clang_TLL.
+add_llvm_library(clangTesting
   CommandLineArgs.cpp
----------------
hokein wrote:
> no related to this patch, I think `clangTestingSupport` is a better name (also align with the LLVM one). 
The LLVM one is called that because it's in llvm/Testing/Support, because it's associated with llvm/Support (but not all the parts are!).
There's nothing else in llvm/Testing, I think it should probably be flattened out instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123610/new/

https://reviews.llvm.org/D123610