[PATCH] D123775: [AST] Support template declaration found through using-decl for QualifiedTemplateName.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 20 02:09:46 PDT 2022


hokein added inline comments.


================
Comment at: clang/lib/AST/ASTImporter.cpp:9189
+    TemplateName UnderlyingTN = QTN->getUnderlyingTemplate();
+    if (UsingShadowDecl *USD = UnderlyingTN.getAsUsingShadowDecl()) {
+      if (ExpectedDecl ToUSDOrErr = Import(USD))
----------------
sammccall wrote:
> why not just `import(UnderlyingTN)` directly, instead of importing its shadowdecl or templatedecl case-by-case?
good catch, not sure how I missed this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123775/new/

https://reviews.llvm.org/D123775



More information about the cfe-commits mailing list