[PATCH] D121868: [cc1as] Add support for emitting the build version load command for -darwin-target-variant

Byoungchan Lee via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 19 23:37:56 PDT 2022


bc-lee added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Darwin.h:495
+  Optional<llvm::Triple> getTargetVariantTriple() const override {
+    return TargetVariantTriple;
+  }
----------------
MaskRay wrote:
> llvm::None
Do you mean to modify the method in `clang/include/clang/Driver/ToolChain.h`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121868/new/

https://reviews.llvm.org/D121868



More information about the cfe-commits mailing list