[PATCH] D86351: WIP: llvm-buildozer

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 19 19:05:54 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Analysis/MemorySSA.cpp:89
 #ifdef EXPENSIVE_CHECKS
-bool llvm::VerifyMemorySSA = true;
+LLVM_THREAD_LOCAL bool llvm::VerifyMemorySSA = true;
 #else
----------------
Do command line flags like this really need to be thread local? Wouldn't ever cl::opt need to be if this is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86351/new/

https://reviews.llvm.org/D86351



More information about the cfe-commits mailing list