[PATCH] D124012: [Clang] Fix references to captured variables in dependant context.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, but please wait a bit before landing so other reviewers have time to weigh in (should be fine to land tomorrow sometime if you don't hear back).



================
Comment at: clang/lib/Sema/SemaLambda.cpp:1378-1383
+  CompleteLambdaCallOperator(
+      Method, Intro.Range.getBegin(), ParamInfo.getTrailingRequiresClause(),
+      MethodTyInfo, ParamInfo.getDeclSpec().getConstexprSpecifier(), Params,
+      ExplicitResultType);
 
+  ContextRAII ManglingContext(*this, Class->getDeclContext());
----------------
cor3ntin wrote:
> aaron.ballman wrote:
> > The previous logic was to enter a mangling context and then check params, but the new logic checks params outside of the mangling context. Is that intentional?
> It has no impact one way or another, but we can't call `CompleteLambdaCallOperator` in the context of the class, so this is simpler.
Okay, thanks for the explanation!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124012/new/

https://reviews.llvm.org/D124012