[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

Steven Wan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 19 10:59:19 PDT 2022


stevewan added a comment.

I don't think the redirect files portion of this patch is well-described in the description, could you please add it?



================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:80
+static bool hasExportListLinkerOpts(const ArgStringList &CmdArgs) {
+  for (size_t i = 0, Size = CmdArgs.size(); i < Size; ++i) {
+    llvm::StringRef ArgString(CmdArgs[i]);
----------------
Since `!=` is preferred, let's switch to that.


================
Comment at: clang/lib/Driver/ToolChains/AIX.cpp:88
+    // If we split -b option, check the next opt.
+    if (ArgString == "-b" && i + 1 < CmdArgs.size()) {
+      ++i;
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119147/new/

https://reviews.llvm.org/D119147



More information about the cfe-commits mailing list