[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

[Roy Jacobson via Phabricator via cfe-commits]

royjacobson added a subscriber: Mordante.
royjacobson added a comment.

So, it seems like this broke one of `basic_arg_format`'s private constructors.. Sorry for that.

  //format_arg.h:167
  explicit basic_format_arg(_Tp __v) noexcept
        requires(same_as<_Tp, char_type> ||
                 (same_as<_Tp, char> && same_as<char_type, wchar_t>)) [....]
  
  //format_arg.h:248
  explicit basic_format_arg(const _Tp& __v) [...]

This is now ambiguous when calling `basic_format_arg(char)` because the argument type is different and comparing constraints is not allowed. @Mordante could you maybe take a look? I've reverted in the meantime.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123182/new/

https://reviews.llvm.org/D123182