[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

Bal√°zs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 19 02:59:06 PDT 2022


steakhal requested changes to this revision.
steakhal added a comment.
This revision now requires changes to proceed.

> A recent review emphasized the preference to use DefaultBool instead of bool for checker options.

What I wanted to highlight is that we should aim for consistency. We should either use that everywhere or nowhere.

To be fair, we should probably use raw bools instead.
They could not only default to `false`, but to `true` as well.

In addition to this, we should prefer the c++ way of initializing these at the declaration directly to either of those values.
IMO we don't need this `DefaultBool` abstraction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123464/new/

https://reviews.llvm.org/D123464



More information about the cfe-commits mailing list