[PATCH] D119296: KCFI sanitizer

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 18 18:57:14 PDT 2022


nickdesaulniers added inline comments.


================
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:1111
+
+  const MCSectionELF &ElfSec = static_cast<const MCSectionELF &>(TextSec);
+  unsigned Flags = ELF::SHF_LINK_ORDER;
----------------
nickdesaulniers wrote:
> or just `cast`.
> https://llvm.org/docs/ProgrammersManual.html#the-isa-cast-and-dyn-cast-templates
err...up/down-cast vertigo. NVM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119296/new/

https://reviews.llvm.org/D119296



More information about the cfe-commits mailing list