[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

Ten Tzen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 18 16:26:12 PDT 2022


tentzen added a comment.

In D80344#3453565 <https://reviews.llvm.org/D80344#3453565>, @bowang wrote:

>> Hi, this patch is just part-1 of Windows SEH feature support.  Part-2 work had been sitting in https://reviews.llvm.org/D102817/new/ since last May 2021.  It's been reviewed, and feedbacks had been addressed. but nobody has approved it.  To handle Hardware Exception in Clang & LLVM, we both patches in.  thanks.
>
> Thanks for the feedback. This feature is really useful.
>
> We are attempting to switch from MSVC to Clang company-wise. We resolved most issues but lastly got stuck by Clang not supporting SEH. I believe we are not an unique case running into this issue. I'd be very happy to see this feature get merged in.

Yes totally understood. but I had been blocked to move forward Part-2 patch https://reviews.llvm.org/D102817/new/  for almost one year.  I cannot just land it in without an "approval".
thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344



More information about the cfe-commits mailing list