[PATCH] D123325: [Clang] Make enabling the new driver more generic

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 18 09:09:41 PDT 2022


yaxunl added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:3885-3888
+  bool UseNewOffloadingDriver =
+      C.isOffloadingHostKind(C.getActiveOffloadKinds()) &&
+      (Args.hasArg(options::OPT_foffload_new_driver) ||
+       Args.hasArg(options::OPT_fopenmp_new_driver));
----------------
If OPT_fopenmp_new_driver is on by default, then OPT_foffload_new_driver will have no effect. Is this intended? Should OPT_fopenmp_new_driver be conditioned for OpenMP offloading only?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123325/new/

https://reviews.llvm.org/D123325



More information about the cfe-commits mailing list