[PATCH] D123909: [Clang] Use of decltype(capture) in parameter-declaration-clause

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 18 06:12:48 PDT 2022


erichkeane added a comment.

1 nit, otherwise no comments.



================
Comment at: clang/lib/Sema/SemaExpr.cpp:2703
+                                                  UnqualifiedId &Id) {
+  InMutableAgnosticContext = true;
+  ExprResult Res = ActOnIdExpression(S, SS, /*TemplateKwLoc*/
----------------
I would probably prefer a RAII object for this bool. It makes it easier later on if we decide this is something that needs to be enabled/disabled in a stack.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123909/new/

https://reviews.llvm.org/D123909



More information about the cfe-commits mailing list