[clang] 33b604d - [OpenMP] Fix linting diagnostics in the linker wrapper
Joseph Huber via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 15 18:19:50 PDT 2022
Author: Joseph Huber
Date: 2022-04-15T21:19:29-04:00
New Revision: 33b604d1c3017a6d09e47384566353efe7bbfe57
URL: https://github.com/llvm/llvm-project/commit/33b604d1c3017a6d09e47384566353efe7bbfe57
DIFF: https://github.com/llvm/llvm-project/commit/33b604d1c3017a6d09e47384566353efe7bbfe57.diff
LOG: [OpenMP] Fix linting diagnostics in the linker wrapper
Summary:
A previous patch had some linter warnings that should've been addressed.
Added:
Modified:
clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
Removed:
################################################################################
diff --git a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
index d202b16516220..e187e57cd22c8 100644
--- a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
+++ b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
@@ -308,7 +308,7 @@ Error extractOffloadFiles(StringRef Contents, StringRef Prefix,
createOutputFile(Prefix + "-" + Kind + "-" + Binary.getTriple() +
"-" + Binary.getArch(),
Suffix, TempFile))
- return std::move(Err);
+ return Err;
Expected<std::unique_ptr<FileOutputBuffer>> OutputOrErr =
FileOutputBuffer::create(TempFile, Binary.getImage().size());
@@ -318,7 +318,7 @@ Error extractOffloadFiles(StringRef Contents, StringRef Prefix,
std::copy(Binary.getImage().bytes_begin(), Binary.getImage().bytes_end(),
Output->getBufferStart());
if (Error E = Output->commit())
- return std::move(E);
+ return E;
DeviceFiles.emplace_back(Kind, Binary.getTriple(), Binary.getArch(),
TempFile);
More information about the cfe-commits
mailing list