[PATCH] D123884: [HLSL][clang][Driver] Support target profile command line option.

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:6701
 
+
 class DXCJoinedOrSeparate<string name> : Option<["/", "-"], name,
----------------
delete


================
Comment at: clang/include/clang/Driver/Options.td:6715
+  Group<dxc_Group>, Flags<[DXCOption, NoXarchOption, CC1Option, HelpHidden]>,
+  HelpText<"Override validator version for module.  Format: <major.minor> ;Default: DXIL.dll version or current internal version.">,
+  MarshallingInfoString<CodeGenOpts<"DxilValidatorVersion">>;
----------------
Remove period from the last sentence of HelpText.
Use just one space for sentence separator. See other options for the prevailing style stating the format.

I see many dxil related options have violated this and I am going to fix them soon.


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:843
+  // HLSL related end of code gen work items.
+  if (LangOpts.HLSL) {
+    getHLSLRuntime().finishCodeGen();
----------------
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements


================
Comment at: llvm/test/Transforms/OpenMP/icv_tracking.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature
-; RUN: opt -S -passes=openmp-opt < %s | FileCheck %s
+; RUN: opt -S -openmp-opt-cgscc < %s | FileCheck %s
+; RUN: opt -S -passes=openmp-opt-cgscc < %s | FileCheck %s
----------------
`opt -S -foo` tests the new PM as well due to `EnableNewPassManager`.

The old style (inherited from legacy pass manager) run lines are being phased out. Don't add new one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123884/new/

https://reviews.llvm.org/D123884