[PATCH] D123840: [Clang][Sema] Fix invalid redefinition error in if/switch/for statement

Jun Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 15 06:39:56 PDT 2022


junaire added a comment.

I also find the code below really awkward:

  S->getParent()->getFlags() & Scope::ControlScope

I find that we have helpers like `Scope::isBlockScope()` `Scope::isisTryScope()` and etc, but no `Scope::isControlScope` and `Scope::isFnTryCatchScope`

I will add these helpers as a NFC patch after this one, that won't need a release note or review right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123840/new/

https://reviews.llvm.org/D123840



More information about the cfe-commits mailing list