[PATCH] D123831: [POC][WIP] Use relative include in extract-api

Zixu Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 14 20:25:54 PDT 2022


zixuw added inline comments.


================
Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:87
+    Dir = DirPath;
+    for (auto NI = path::begin(File), NE = path::end(File),
+              DI = path::begin(Dir), DE = path::end(Dir);
----------------
I still need to dig into this logic and see what kinds of special cases it's trying to handle, and do we really need these instead of simply `File.startswith(Dir)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123831/new/

https://reviews.llvm.org/D123831



More information about the cfe-commits mailing list