[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

Thu Apr 14 16:07:25 PDT 2022

tentzen added a comment.

In D80344#3450940 <https://reviews.llvm.org/D80344#3450940>, @bowang wrote:

> Any updates on this patch? Would like to see it moving forward.
>
> I was trying to use Google Breakpad with Clang. Breakpad is a crash handling library that generates a minidump at crash. The exception handler on Windows relies on SEH.
>
> Breakpad works fine with MSVC. But when it is built with Clang, the exception code returned in `exinfo>ExceptionRecord->ExceptionCode` is incorrect. In my test program, an access to nullptr should trigger `EXCEPTION_ACCESS_VIOLATION` but what's returned is `EXCEPTION_BREAKPOINT`. I suspect it is due to Hardware Exception Handling in Clang.
>
> I tried to add flag `-fasync-exceptions` but the problem stays the same.
>
> I tried to add flag `-fseh-exceptions` but received an error `error: invalid exception model 'seh' for target 'x86_64-pc-windows-msvc19.0.24245'`
>
> I'm not fully sure whether this patch can address my issue, but would appreciate if anyone could shed some light on this. Thanks in advance.

Hi, this patch is just part-1 of Windows SEH feature support.  Part-2 work had been sitting in https://reviews.llvm.org/D102817/new/ since last May 2021.  It's been reviewed, and feedbacks had been addressed. but nobody has approved it.  To handle Hardware Exception in Clang & LLVM, we both patches in.  thanks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344