[PATCH] D122008: [flang][driver] Add support for generating executables
Andrzej Warzynski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 14 06:01:47 PDT 2022
awarzynski added a comment.
@h-vetinari & @rouson, thanks for the encouragement!
In D122008#3450214 <https://reviews.llvm.org/D122008#3450214>, @h-vetinari wrote:
> I'd be more than a little surprised that there's no way to do this. Have you tried CMAKE_Fortran_FLAGS <https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_FLAGS.html>? AFAICT, the environment variables should be respected.
I completely forgot about `CMAKE_Fortran_FLAGS`! Indeed, it worked :) I really appreciate you doing all that digging and the suggestion itself! Yes, sounds like we can return to Option 2, which is fantastic news and great team effort!
I will post an updated version of this patch shortly. My suggestion for the new flag: `-flang-experimental-exec`. Hopefully not too long or to vague and informative enough. WDYT?
In D122008#3450346 <https://reviews.llvm.org/D122008#3450346>, @rouson wrote:
> I don't know the time required to complete the remaining tasks, but the following issues show 216 of 235 tasks completed with 2 in progress:
Thanks for that executive summary @rouson, it does look encouraging :) Unfortunately, upstreaming is effectively on hold ATM. People are not too keen to commit to any dates (understandable), but we (Arm) will continue working towards the LLVM 15 target (fingers crossed!).
**Summary**
AFAICT, Option 2 addresses all the issues raised here and (more importantly) unblocks a few new streams of development. IMO, it's a very good compromise and we should go ahead with it. I will leave this here for a few more days in case people have more comments.
Thank you,
-Andrzej
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D122008/new/
https://reviews.llvm.org/D122008
More information about the cfe-commits
mailing list