[PATCH] D121984: [RISCV] Moving RVV intrinsic type related util to clang/Support

Thu Apr 14 05:29:11 PDT 2022

aaron.ballman added a comment.

In D121984#3450956 <https://reviews.llvm.org/D121984#3450956>, @kito-cheng wrote:

> Hi @aaron.ballman:
>
>> Why shouldn't this live in clang/utils/TableGen along with the others?
>
> We plan to use those stuffs on clang side in https://reviews.llvm.org/D111617, my original change was put those stuffs on `llvm/Support`, but actually those stuffs are only used for clang and clang-tblgen, so that's why we try to create `clang/Support`.
>
> It's target specific but need to used in `clang` and `clang-tblgen` so target specific stuffs should putting that in `llvm/lib/Target/RISCV` in theory, but that made clang dependent on that.

Thank you for the explanation. I still don't think this is really "Support" material, but I'm also struggling to think of a better place to put it in an existing directory in Clang aside from Basic, but that would still be a bit of a layering violation it feels like. So I think I'm convinced that `Support` is a reasonable place to put it.

Should it live within a `RISCV` direction inside of the `Support` directory? Or should we use folders like that for host platform support files instead of target platform support files (as the LLVM `Support` directory appears to do)?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121984/new/

https://reviews.llvm.org/D121984