[PATCH] D123773: [clang][analyzer][ctu] Make CTU a two phase analysis

[Gabor Marton via Phabricator via cfe-commits]

martong added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:167
+  // Let CTU run as many steps we had in the single TU run.
+  // However, we need at least some minimal value to pass those lit tests that
+  // report a bug only in the CTU mode.
----------------
Well, not just for lit tests, I'll update the comment.


================
Comment at: clang/test/Analysis/ctu-main.cpp:178
 
+  // FIXME we should report an UNKNOWN as well for all external variables!
   clang_analyzer_eval(extInt == 2); // expected-warning{{TRUE}}
----------------
This FIXME is outdated, got here during rebase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123773/new/

https://reviews.llvm.org/D123773