[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

Qiongsi Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 13 12:04:47 PDT 2022


qiongsiwu1 updated this revision to Diff 422589.
qiongsiwu1 added subscribers: abdulras, compnerd.
qiongsiwu1 added a comment.
Herald added subscribers: pcwang-thead, luke957, s.egerton, simoncook.

Addressing review comments:

1. @chill pointed out that the generated headers are missing. The generated headers are added now.
2. @pengfei pointed out that some x86 headers are listed out of order. The list is sorted now.
3. @pengfei also commented on `mm_malloc.h`. I think it is needed for `x86` and `ppc`. The header is added to these two targets.

@abdulras @compnerd May I get your comments on the `riscv` target?

Thank you all!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123498/new/

https://reviews.llvm.org/D123498

Files:
  clang/lib/Headers/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123498.422589.patch
Type: text/x-patch
Size: 12207 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220413/0695379c/attachment.bin>


More information about the cfe-commits mailing list