[PATCH] D123655: [clang-tidy] Add portability-std-allocator-const-t check

[Louis Dionne via Phabricator via cfe-commits]

ldionne added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/portability-std-allocator-const-t.rst:11
+
+libstdc++ never supports ``std::allocator<const T>`` and containers using them.
+Since GCC 8.0 (`PR48101 <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=48101>`),
----------------
sammccall wrote:
> It's a little confusing to call out only libstdc++ here without context when libc++ is the odd-one out.
> 
> Maybe first mention that libc++ supports this as an extension that may be removed in the future?
> 
> And if we're mentioning libstdc++'s behavior we should probably mention MS STL too which is similar to libstdc++: https://godbolt.org/z/c4o5nc66v
I think I'd rather not mention libc++ at all -- I don't know that we ever documented that extension, and since we're actively trying to remove it, it might be better to just not say anything. Or we could say "It works on libc++, but it's non-standard and it may not work in the future".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123655/new/

https://reviews.llvm.org/D123655