[PATCH] D122691: [clang][Sema] Add flag to LookupName to force C/ObjC codepath

Wed Apr 13 10:55:16 PDT 2022

arphaman added a comment.

The change itself LGTM.

It would be really good if we can have a unit test that tests the new API when it lands, to ensure that this is tested in LLVM-project itself , in addition to Swift. Do you think it's possible to write a unit tests that constructs a compiler instance, parses a sample C++ file, and then you can use the Sema to try to invoke this `LookupName` API to perform the lookup to verify that it works as expected? I think it should be possible to construct such a unit test.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122691/new/

https://reviews.llvm.org/D122691