[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

Qiongsi Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 13 07:23:13 PDT 2022


qiongsiwu1 added a subscriber: momchil.velikov.
qiongsiwu1 added a comment.

May I get some comments from the rest of the reviewers for the respective platforms? 
@momchil.velikov @chill: arm
@pengfei : x86
@jdoerfert: cuda
@yaxunl : opencl
@kaz7 : ve
@bcain : hexagon
@sdardis : mips

Thanks so much!



================
Comment at: clang/lib/Headers/CMakeLists.txt:173
   __wmmintrin_pclmul.h
   x86gprintrin.h
   x86intrin.h
----------------
abhina.sreeskantharajan wrote:
> nit: There are some x86 headers here that appear to be x86 only. Should these be moved to x86_files list?
Thanks for the comment! Yes indeed. I think currently the `x86gprintrin.h` header is in the `x86_files` list (list starts at line 88). Did I miss some other x86 files? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123498/new/

https://reviews.llvm.org/D123498



More information about the cfe-commits mailing list