[PATCH] D107636: [analyzer][solver] Compute adjustment for unsupported symbols as well

[Gabor Marton via Phabricator via cfe-commits]

martong requested changes to this revision.
martong added a comment.
This revision now requires changes to proceed.

I am not sure if this patch makes sense at all because the adjustment handling logic is restricted to handle SymInt expressions only.



================
Comment at: clang/lib/StaticAnalyzer/Core/RangedConstraintManager.cpp:82-86
       if (IsExpectedEqual) {
         return assumeSymNE(State, CanonicalEquality, Zero, Zero);
       }
 
       return assumeSymEQ(State, CanonicalEquality, Zero, Zero);
----------------
ASDenysPetrov wrote:
> Do we need the same changes here as below?
I believe, the adjustment is deliberately Zero here. This is because we are dealing with a SymSym expr, and the adjustment logic is capable of handling only a SymInt expr.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107636/new/

https://reviews.llvm.org/D107636