[PATCH] D123672: [clangd] Export preamble AST and serialized size as metrics
Adam Czachorowski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 13 05:21:46 PDT 2022
adamcz added inline comments.
================
Comment at: clang-tools-extra/clangd/Preamble.cpp:500
+ if (Stats != nullptr) {
+ Stats->TotalBuildTime = PreambleTimer.getTime();
----------------
This is a significant change. You are now exporting this information for failed preamble builds. Do you think these are interesting? It might make the data a bit confusing (i.e. lots of small "built in <1s, did not read any files) when something is really wrong with preamble.
I think we should either only export on successful preamble OR add a boolean "success" dimension to the metric.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123672/new/
https://reviews.llvm.org/D123672
More information about the cfe-commits
mailing list