[PATCH] D123627: Correctly diagnose prototype redeclaration errors in C

[James Y Knight via Phabricator via cfe-commits]

jyknight accepted this revision.
jyknight added inline comments.


================
Comment at: clang/test/Sema/warn-deprecated-non-prototype.c:64-70
 // FIXME: we get two diagnostics here when running in pedantic mode. The first
 // comes when forming the function type for the definition, and the second
 // comes from merging the function declarations together. The second is the
 // point at which we know the behavior has changed (because we can see the
 // previous declaration at that point), but we've already issued the type
 // warning by that point. It's not ideal to be this chatty, but this situation
 // should be pretty rare.
----------------
Reword to indicate that the second diagnostic is now an error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123627/new/

https://reviews.llvm.org/D123627