[PATCH] D122008: [flang][driver] Add support for generating executables

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:392
+  //    * on some platforms, we may need to use lib64 instead of lib (you can use
+  //    CLANG_LIBDIR_SUFFIX to automate this)
+  //    * this logic should also work on other similar platforms too, so we
----------------
I think the multilib style CLANG_LIBDIR_SUFFIX is being phased out in clang driver, so no need for the comment.


================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:397
+      llvm::sys::path::parent_path(TC.getDriver().Dir);
+  llvm::sys::path::append(DefaultLibPath, Twine("lib"));
+  CmdArgs.push_back(Args.MakeArgString("-L" + DefaultLibPath));
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122008/new/

https://reviews.llvm.org/D122008